cpu-profiles: Alternative implementation#10
Closed
olivereanderson wants to merge 12 commits into
Closed
Conversation
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.33.1 to 1.34.0. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.33.1...v1.34.0) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-version: 1.34.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
When invoking the script chown shows a warning.
chown: warning: '.' should be ':': ‘1000.1000’
From `info coreutils 'chown invocation'`.
Some older scripts may still use ‘.’ in place of the ‘:’ separator.
POSIX 1003.1-2001 (*note Standards conformance::) does not require
support for that, but for backward compatibility GNU ‘chown’ supports
‘.’ so long as no ambiguity results, although it issues a warning and
support may be removed in future versions. New scripts should avoid the
use of ‘.’ because it is not portable, and because it has undesirable
results if the entire OWNER‘.’GROUP happens to identify a user whose
name contains ‘.’.
Signed-off-by: Wei Liu <liuwe@microsoft.com>
6 tasks
olivereanderson
commented
Aug 1, 2025
| // function, index, register triple via `crate::x86_64::impl_cpuid_feature_flags!` | ||
| const { | ||
| Self { | ||
| edx_1: FF::<1, 0, { CpuidReg::EDX as u8 }>::from_names(&[ |
Author
There was a problem hiding this comment.
For better or worse: The compiler does not manage to infer the const generic parameters when they are left out here, even though we have specified them in the field declaration of the struct.
olivereanderson
commented
Aug 1, 2025
Comment on lines
+19
to
+21
| // Placing this in a const block ensures compile time evaluation and we get isntant feedback | ||
| // (even from the LSP) if the lists contain arguments that are not defined for the given | ||
| // function, index, register triple via `crate::x86_64::impl_cpuid_feature_flags!` |
Author
There was a problem hiding this comment.
I verified this statement by chance when developing 😄
olivereanderson
force-pushed
the
oanderson/cpu-profiles
branch
from
f0461da to
5c1ae50
Compare
phip1611
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This demonstrates an alternative way of specifying cpu features (per profile).
We may or may not prefer this alternative to the original approach.